Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting menu colors, active and hover effects on LCARS theme #2309

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Adjusting menu colors, active and hover effects on LCARS theme #2309

merged 2 commits into from
Aug 25, 2022

Conversation

rdwebdesign
Copy link
Member

What does this PR aim to accomplish?:

  • Better colors for menu groups, hover effect and active menu item.
  • clean old and unused styles.

How does this PR accomplish the above?:

  • New CSS using variables to simplify the code.

What documentation changes (if any) are needed to support this PR?:

none

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  • I have read the above and my PR is ready for review. Check this box to confirm

@rdwebdesign rdwebdesign force-pushed the tweak/lcars_menu branch 5 times, most recently from cb6dfb7 to da23b4e Compare August 24, 2022 07:14
@rdwebdesign rdwebdesign requested a review from a team August 24, 2022 07:16
yubiuser
yubiuser reviewed Aug 24, 2022
View reviewed changes
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The animation during sidebar closing looks really smooth. But when the sidebar expands, it suddenly removes the left part of the light blue bar and starts only afterwards to collapse. Maybe you can prevent the sudden blackness?

Peek 2022-08-24 20-15

@yubiuser
Copy link
Member

Add: also during collapsing, the light blue bar extends a bit and closes the small black gap....

@rdwebdesign
Adjusting menu colors, active and hover effects
c939e32 
- new menu button colors;
- change sidebar background color;
- small adjustments.

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
@rdwebdesign rdwebdesign force-pushed the tweak/lcars_menu branch 2 times, most recently from 8720684 to 51e9826 Compare August 25, 2022 01:52
@rdwebdesign
Copy link
Member Author

Fixed.

fix_background

@rdwebdesign rdwebdesign force-pushed the tweak/lcars_menu branch 2 times, most recently from 1117803 to 07866de Compare August 25, 2022 02:49
@rdwebdesign rdwebdesign requested review from yubiuser and a team August 25, 2022 02:51
@rdwebdesign
Fix top background during animation (desktop and mobile)
8b084a6 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
yubiuser
yubiuser reviewed Aug 25, 2022
View reviewed changes
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still a bit floppy on mobile. I tried to capture it on using dev tools/mobile, here it does not happen every time, but on real mobile it's always happening.

Peek 2022-08-25 09-32

@rdwebdesign
Copy link
Member Author

I think the problem there is the animation speed combined with the "custom" background.

The sidebar and the content-wrapper elements are moving in slightly different speeds and you can see a "gap".

To adjust the animation we will need change the javascript in adminlte.min.js.

I don't want to do it.
This is a small glitch, in just one theme.

@yubiuser yubiuser changed the title Adjusting menu colors, active and hover effects Adjusting menu colors, active and hover effects on LCARS theme Aug 25, 2022
@yubiuser yubiuser merged commit 15b83bb into devel Aug 25, 2022
@yubiuser yubiuser deleted the tweak/lcars_menu branch August 25, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yubiuser yubiuser yubiuser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdwebdesign @yubiuser